don't use invalidated iterator

d29fab48 · Fabian Kosmale · Fabian Kosmale · 260f16bd · d29fab48
Commit d29fab48 authored Mar 16, 2014 by Fabian Kosmale Committed by Fabian Kosmale Mar 16, 2014
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

syncoperation.cpp syncoperation.cpp +5 -2

No files found.
--- a/syncoperation.cpp
+++ b/syncoperation.cpp
@@ -187,12 +187,15 @@ void SyncOperation::install(QUuid uuid, QList< Akabei::Package* > packages)
            continue;
        mostRecent = (*it1);
        
-        for (it2 = it1 + 1; it2 != packages.end(); it2++) {
+        it2 = it1 + 1;
+        while (it2 != packages.end()) {
            if ((*it1)->name() == (*it2)->name()) {
                if ((*it2)->version() > (*it1)->version()) {
                    mostRecent = (*it2);
                }
-                packages.erase(it2);
+                it2 = packages.erase(it2);
+            } else {
+                ++it2;
            }
        }